Code review — dashboard full build

• Branch: feature/dashboard-full-build → master
• Date: 2026-06-23
• Scope: 3 files (+249 / −5) — dashboard-page.{ts,html,spec.ts}
• Reviewer: code-reviewer agent over git diff origin/master...HEAD, synthesized.

Deterministic gate

Check	Result
nx lint web	✓ 0 errors
nx test web	✓ 177 passed (+3)
coverage gate	✓ stmts 77.8% · branches 67.7% · fns 69.0% · lines 82.8% (all ≥ threshold)
nx build web	✓

What's in the build (design-system dashboard gaps)

• Mandate drill-down — clicking a .dash-card opens a read-only breakdown: large completion ring (.dash-ring.lg), stacked status bar (.dash-bar + legend), full chronological activity list (.dash-act with assignee + .dash-act-gacx reward), and a "← Back to mandates" link. Driven by a selected signal + detail computed.
• GACx on activity rows — task.gacxReward shown in the people view too.
• "Finished · last 30 days" — dataLatest (max activity timestamp) anchors a 30-day window for the people view's finished list; no dates → includes all (safe fallback).

No CSS added — all .dash-* breakdown classes already exist in dispatch-theme.css.

Findings

🔴 Blocking — none.

🟡 Should-fix — none.

🟢 Nits (all acceptable, no change)

• Date.parse treats date-only ISO (2026-06-20) as UTC vs datetime as local — harmless given all comparisons are relative over a 30-day window.
• @if (task.gacxReward) hides a zero reward — intentional, matches the existing @if (task.due) pattern.
• denom = total || 1 guards division but is unreachable at 0 (zero-task mandate → all segments filtered out → bar block skipped). Correct.

Verified clean

Signal reads are all calls; computeds chain correctly. selected stores only an id, so detail re-resolves each recompute and falls back to the grid if the mandate disappears (no stale object). selectMandate(undefined) no-ops; unknown id → detail null → grid stays. 30-day no-date fallback is intended. .slice() before .sort() avoids mutating source. .dash-card a11y complete (role/tabindex/aria-label/keydown.enter/keydown.space+preventDefault). [style.--pct] / [style.width.%] valid. Detail view replaces grid+stats via @else if (detail(); as det) — stat-strip hidden in detail mode is intended. Models fidelity confirmed (gacxReward/scope/rate/duration all typed). The 3 new specs assert real behavior (drill-down DOM, back-to-grid, guards, assignee resolution, 30-day window via the "1 finished" toggle).

Verdict

Ship it — 0 blocking, 0 should-fix. Clean, correct, well-tested. Awaiting a visual pass + sign-off before push.